Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds more predicates for Hyrax' internal metadata. #6820

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Adds more predicates for Hyrax' internal metadata. #6820

wants to merge 1 commit into from

Conversation

bwatson78
Copy link
Contributor

Summary

Adds more predicates for Hyrax' internal metadata.

Guidance for testing, such as acceptance criteria or new user interface behaviors:

  • Viewing a Fedora object with all of these fields populated in its UI, the predicates provided will replace the default mock predicates (example.com).

Type of change (for release notes)

  • notes-minor New Features that are backward compatible
  • notes-valkyrie Valkyrie Progress

@samvera/hyrax-code-reviewers

@bwatson78 bwatson78 added File Set impacts the File Set part of PCDM Model File impacts the File part of PCDM Model notes-minor Release Notes: Non-breaking features notes-valkyrie Release Notes: Valkyrie specific valkyrie-fedora labels May 31, 2024
@bwatson78 bwatson78 self-assigned this May 31, 2024
@bwatson78 bwatson78 mentioned this pull request May 31, 2024
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented May 31, 2024 •
edited
Loading

Test Results

    17 files  ±0      17 suites  ±0   2h 22m 7s ⏱️ +41s
 6 705 tests ±0   6 407 ✅ ±0  297 💤 ±0  1 ❌ ±0 
13 178 runs  ±0  12 781 ✅  - 1  395 💤 ±0  2 ❌ +1 

For more details on these failures, see this check.

Results for commit 079f081. ± Comparison against base commit 59a42ad.

This pull request removes 272 and adds 272 tests. Note that renamed tests count towards both. 
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f14897bd708>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007fba83ec5c80>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f148a194600>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007fba83ffc450>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: 133a9822-768b-48ad-a346-396b70d63b8b
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: d2a1f5ab-99e3-4f8a-af33-0f3fdb07e5a2
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: c5cdc4e2-8185-4228-a98c-b012fbea7e7f
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit Hyrax::AdministrativeSet: 67871b8d-cc2d-4fee-8a21-c9ae70f921ec
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update AdminSet: 84ed5efd-d6ce-4bf0-9187-6e1f28380843
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update Hyrax::AdministrativeSet: 7f6fdad7-4891-48e5-b492-1da2b3ab04db
…

spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f400f19dc18>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007fba39114b08>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f400f259c60>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007fba2d49ca98>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: 365d44b5-fed8-4184-9ae5-a92e0ab22abb
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: edbdb5ab-2058-4c7f-b121-cedbe8aac0f8
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: 729761d5-03a2-4eab-9a47-f84f511a6561
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit Hyrax::AdministrativeSet: 90a87666-3d35-4416-b4a2-6f048684ac46
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update AdminSet: ac202228-f6df-4249-b2fb-2cea9d55c3dc
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update Hyrax::AdministrativeSet: d53b0425-9ae8-4b4c-9cb5-7f6ceebee4cd
…

♻️ This comment has been updated with latest results.

@dlpierce dlpierce force-pushed the adds_more_internal_metadata_predicates branch from c064812 to 5a8fd9b Compare July 5, 2024 19:32
@bwatson78 bwatson78 force-pushed the adds_more_internal_metadata_predicates branch from 5a8fd9b to 079f081 Compare July 24, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bwatson78 bwatson78

Labels
File Set impacts the File Set part of PCDM Model File impacts the File part of PCDM Model notes-minor Release Notes: Non-breaking features notes-valkyrie Release Notes: Valkyrie specific valkyrie-fedora
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bwatson78